Reviewed 2 of 5 files at r1, all commit messages.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @liorgold2 and @orizi)

crates/cairo-lang-sierra-ap-change/src/compute.rs line 54 at r1 (raw file):

}

/// Helper to implement the `InvocationApChangeInfoProvider` for the equation generation.

Wrong doc.

crates/cairo-lang-sierra-ap-change/src/compute.rs line 134 at r1 (raw file):

                | ApChange::Known(_)
                | ApChange::DisableApTracking => {
                    if let Some(locals) = self.locals.get(&idx) {

Consider changing it to locals_count.

Code quote:

locals

Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @liorgold2)

crates/cairo-lang-sierra-ap-change/src/compute.rs line 54 at r1 (raw file):

Done.

crates/cairo-lang-sierra-ap-change/src/compute.rs line 134 at r1 (raw file):

it isn't count - it is size. Done.

Reviewed 2 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @liorgold2 and @orizi)

crates/cairo-lang-sierra-ap-change/src/compute.rs line 319 at r2 (raw file):

    }

    /// Returns the locals count for a statement.

Suggestion:

e locals size

crates/cairo-lang-sierra-ap-change/src/compute.rs line 354 at r2 (raw file):

}

/// Calculates gas information for a given program.

Suggestion:

/// Calculates the ap change information for a given program.

crates/cairo-lang-sierra-ap-change/src/lib.rs line 54 at r2 (raw file):

}

/// Calculates gas information for a given program.

Suggestion:

ap change

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Reviewed 9 of 9 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)